Should we add more logging to Play's evolutions?


(Tanin Na Nakorn) #1

Hi Players,

I’ve noticed that we don’t have that many logging statements in the Evolution plugin. I wonder if it’s a good idea to add more logging statements in different places.

For example, adding a logging statement here will indicate which statement in an evolution file fails.

Alternatively, we can add a log statement around here as well: https://github.com/playframework/playframework/blob/master/framework/src/play-jdbc-evolutions/src/main/scala/play/api/db/evolutions/EvolutionsApi.scala#L327

Play’s evolution isn’t run frequently, so over-logging might be ok.

For a concrete example, I’ve encountered a case where I have multiple statements in one evolution file, and the logs from Play weren’t helpful. It only said something like invalid character at position 61.

I’d love to make this change my first commit to Play framework as well if it sounds like a good idea.

Please let me know.

Thank you


(Marcos Pereira) #2

Hi @tanin47,

You may be interested in this issue:

A pull request would be very welcomed here. :slight_smile:

Best