Handler which wraps Handler/Future[Handler]

domdorn · August 14, 2019, 11:38am

I’m using compile time dependency injection in my app and create my routes using SIRD.
What I tried to achieve was kind of a filter that I can strictly apply to one or more Routes object/Router simply by wrapping the Routes/Router.

I’ve created this by implementing a Routes which is wrapping the existing Routes in here: https://gist.github.com/domdorn/0babae52f9a96b1db6e38aa77690edbf

In my code, I’m calling a future and then mapping … unfortunately, there is no existing Handler thats able to return/wrap a Future[Handler] ( EssentialAction allows me to return Future[Result] / Accumulator[ByteString, Result] ), so at the moment, I have to do a Await.result() on the future :(

I thought about creating a own Handler (e.g. like EssentialAction) that is able to wrap a Handler and do the proper lifting/future handling, but I think I’d either have to change

github.com

playframework/playframework/blob/79c25702d678f8c7fe73f64cfbc2e0105f0b397e/transport/server/play-akka-http-server/src/main/scala/play/core/server/AkkaHttpServer.scala#L365


  case Success(app) => app.errorHandler
  case Failure(_)   => DefaultHttpErrorHandler
}


// default execution context used for executing the action
implicit val defaultExecutionContext: ExecutionContext = tryApp match {
  case Success(app) => app.actorSystem.dispatcher
  case Failure(_)   => system.dispatcher
}


(handler, upgradeToWebSocket) match {
  //execute normal action
  case (action: EssentialAction, _) =>
    runAction(tryApp, request, taggedRequestHeader, requestBodySource, action, errorHandler)
  case (websocket: WebSocket, Some(upgrade)) =>
    val bufferLimit = context.config.configuration
      .getDeprecated[ConfigMemorySize]("play.server.websocket.frame.maxLength", "play.websocket.buffer.limit")
      .toBytes
      .toInt


    websocket(taggedRequestHeader).fast.flatMap {

or

github.com

playframework/playframework/blob/ab6697f494a000ba8d19768e9d04eed3bb8cdbf7/core/play/src/main/scala/play/api/http/HttpRequestHandler.scala#L220


    case Some(r) =>
      // A WebCommand returned a result
      (request, ActionBuilder.ignoringBody { r })
    case None =>
      // 1. Query the router to get a handler
      // 2. Resolve handlers that preprocess the request
      // 3. Modify the handler to do filtering, if necessary
      // 4. Again resolve any handlers that do preprocessing
      val routedHandler                              = routeWithFallback(request)
      val (preprocessedRequest, preprocessedHandler) = Handler.applyStages(request, routedHandler)
      val filteredHandler                            = filterHandler(preprocessedRequest, preprocessedHandler)
      val (preprocessedPreprocessedRequest, preprocessedFilteredHandler) =
        Handler.applyStages(preprocessedRequest, filteredHandler)
      (preprocessedPreprocessedRequest, preprocessedFilteredHandler)
  }
}


/**
 * Apply any filters to the given handler.
 */
@deprecated("Use filterHandler(RequestHeader, Handler) instead", "2.6.0")

to make this work.

Any input would be highly appreciated.
And yes, I know I could create a normal play.api.mvc.Filter, but that is not the question here.

Topic		Replies	Views
Play 2.7 Error Handler Play Framework	3	1371	December 23, 2018
Exception Handling Play Framework	8	1212	November 17, 2020
Chained ActionFunction stucks Play Framework scala	7	1560	October 21, 2021
PlayFramework ErrorHandling onClientError Play Framework akka , java	4	981	June 18, 2021
Override "timely response" error page? Play Framework	7	713	May 18, 2018

Handler which wraps Handler/Future[Handler]

Related Topics